The contribution that taught me to write smaller patches

My proudest early contribution was also my worst: a 400-line pull request that fixed a bug, refactored two modules, and renamed things I found unclear. It sat in review for three weeks and died. The maintainer's only comment: "This is three PRs, and I only needed one."

What the failure taught

Review capacity is the bottleneck of every project. A maintainer's queue is time, and my big PR consumed a day of it before offering any value. Small PRs give value per minute of review — that's the actual currency.

Scope is a promise you make to reviewers. One fix means the review is about the fix. Mix in refactors and every comment splits across concerns, nothing lands, and the PR drowns in its own ambition.

The unsolicited refactor is a tax. Those unclear names I renamed? Someone wrote them on purpose, or at least with context I lacked. Changing them inside my bug fix made my diff someone else's surprise.

My rules now

• one PR, one purpose — if I spot an unrelated fix, it becomes its own PR
• fix the bug first, propose improvements second, as issues
• aim for diffs a maintainer can read in one sitting — under a couple hundred lines

The three-week death of that PR cost more time than it saved. Its lesson was free forever.